yekingyan / obsidian-open-in-other-editor

Open current active file in gVim or VScode.
MIT License
18 stars 10 forks source link

Allow editor to open files selected from file browser #6

Open mariomui opened 1 year ago

mariomui commented 1 year ago

TESTING

CONCERNS

This reuses the code for open so it will fail gracefully for anything not mac. As such, discussion needs to be had on the UI side. My concern is that the contextmenu is too busy for all 3 editors to have their own editors. There are three solutions.

The best option would be to allow the toggle to create the editors in hand. So that each one can appear in the contextmenu. Or none at all.

I have used Notices to replace warning messages so the user has more feedback on code behavior.

--Raw-- Open folder in vscode. Overload open. Add seperator and tap for setting display builder. Remove console logs. Open multiple files. Better notification messages. Type improvements: settings config , editor consts Refactor contextmenus feature.

mariomui commented 1 year ago

@yekingyan This commit is pretty standalone but it could use support from: a) the ui toggling feature , one to remove contextmenu child, one to add a context menu child.

b) A unit testing apparatus like jest.

c) Someone has to do the appropriate gvimopen and nvmopen functions.

yekingyan commented 1 year ago

Thank you for your pull request! I appreciate the effort you put into incorporating the functionality into the right-click menu. It's a valuable addition to the project.

As you mentioned, it would be ideal to offer users an option to toggle their preferred editor. This way, they can choose which editor appears in the context menu or even opt not to display any editors. Implementing this functionality may require some adjustments on the settings page.

However, I do have some concerns regarding consistency across various platforms. It would be wonderful if we could address this issue to ensure a smooth experience for users using different operating systems.

All in all, I think your submission is an excellent idea. Thank you again for your contribution.

mariomui commented 1 year ago

Even though the folder feature is ready, I'm going to include the ability to toggle/remove the feature from the file explorer contextmenu.

By default I will have it remain blank.

That will be the scope of this ticket.