search

yeldiRium / st3k101

UNMAINTAINED.
2 stars 1 forks source link

Broken Link for Submission Confirmation #108

Closed ciordashertel closed 5 years ago

ciordashertel commented 5 years ago

The link in the email send to the users after their submission is broken:

Hi there! You've recently participated in the survey Coolness. To confirm your submission, please follow the link below:

http://https://survey.edutec.guru/api/response/verify/659a4dfc9289a292d1a7ec2fc9baf18a <

In the backend.env the domain is set as: DOMAIN_NAME=https://survey.edutec.guru

strangedev commented 5 years ago

Yes, this happens because the DOMAIN_NAME environment variable should not contain a protocol specification.

This case should be detected when building the URL nevertheless.

strangedev commented 5 years ago

Follow up: The logic building the URL assumes http at the moment. This is not correct, but the backend needs a way of knowing whether http or https should be used. Maybe the protocol should be part of the DOMAIN_NAME after all.