search

yeldiRium / st3k101

UNMAINTAINED.
2 stars 1 forks source link

tests should be run before building images #26

Closed yeldiRium closed 6 years ago

yeldiRium commented 6 years ago

Unittests that do not require the built images should be run before building.

This is also necessary for greenkeeper to work, since it needs to update the lockfile, than run tests, then push the lockfile. This can't be done inside the image, thus tests need to be run outside of it.

yeldiRium commented 6 years ago

Now running tests based on Dockerfiles does not make much sense anymore.

I will leave the build-script logic as is for the moment, but we need to rethink how we execute our tests.

This might be easier in split repos, as suggested and discussed in #23.