yeldiRium / st3k101

UNMAINTAINED.
2 stars 1 forks source link

[Bugfix] grid safari #72

Closed yeldiRium closed 5 years ago

yeldiRium commented 5 years ago

This will resolve #71.

The only problem was the grid styling on the button instance.

I rewrote the markup and used a new ripple implementation that is mainly css and very low js. This should be faster than before and work on all supported browsers.

Also I think we now don't need gsap anymore. I'll probably remove it and update this pr.


This change is Reviewable

codecov[bot] commented 5 years ago

Codecov Report

Merging #72 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #72   +/-   ##
======================================
  Coverage      0.2%   0.2%           
======================================
  Files           56     56           
  Lines         1438   1438           
  Branches       127    127           
======================================
  Hits             3      3           
  Misses        1308   1308           
  Partials       127    127

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb4b0fb...a7408f5. Read the comment docs.

yeldiRium commented 5 years ago

Yay, we just got 58 packages lighter :joy: GSAP is gone.