yeldiRium / st3k101

UNMAINTAINED.
2 stars 1 forks source link

[FEATURE] Reordering of owned survey items #77

Closed strangedev closed 6 years ago

strangedev commented 6 years ago

This PR resolves #75 . It includes a database schema and data migration to add the position attribute to Question and Dimension. Positioning of survey items within the parent item may be updated via the API. Currently, the API does not enforce uniqueness on the position attribute, as this is not needed for the sort to work. The frontend now displays up and down arrows for children of concrete survey items which allow re-ordering.

In order to update an existing database to the new revision, run flask db upgrade from the backend container.


This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #77 into develop will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #77      +/-   ##
==========================================
- Coverage     0.22%   0.21%   -0.01%     
==========================================
  Files           56      56              
  Lines         1360    1364       +4     
  Branches       111     111              
==========================================
  Hits             3       3              
- Misses        1246    1250       +4     
  Partials       111     111
Impacted Files Coverage Δ
frontend/src/api/Util/Parse.js 0% <ø> (ø) :arrow_up:
frontend/src/model/SurveyBase/Dimension.js 0% <0%> (ø) :arrow_up:
frontend/src/model/SurveyBase/Question.js 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 687851f...5ba68fd. Read the comment docs.