:environment ignored when creating a new client?

[pupeno]

I noticed my :environment is ignored when I create a new client in this way:

(def yeller-client (yeller/client {:token       (:yeller-token env)
                                   :environment (:environment env)}))

Looking at the code, I cannot see :environment ever being inspected: https://github.com/yeller/yeller_clojure/blob/master/src/yeller/clojure/client.clj#L135-L167

[yellerbot]

Hi,

That happens here: https://github.com/yeller/yeller_clojure/blob/master/src/yeller/clojure/client.clj#L105, called from https://github.com/yeller/yeller_clojure/blob/master/src/yeller/clojure/client.clj#L166

This was a bug in older versions of the client (https://github.com/yeller/yeller_clojure/commit/f2efea10a3bf7255065d856cafe16cd59e42e90b was the commit that fixed it), so bumping your client version should fix this problem.

Thanks

Tom

On Fri, Oct 23, 2015, at 12:57 PM, J. Pablo Fernández wrote:

I noticed my :environment is ignored when I create a new client in this way:

(def yeller-client (yeller/client {:token (:yeller-token env) :environment (:environment env)})) Looking at the code, I cannot see :environment ever being inspected: https://github.com/yeller/yeller_clojure/blob/master/src/yeller/clojure/client.clj#L135-L167

— Reply to this email directly or view it on GitHub[1].

Links:

1. https://github.com/yeller/yeller_clojure/issues/4

[ku1ik]

Would be nice to update the installation instructions within the app, which say to use version 1.2.1 (which has this bug). I wasted an hour until I realized that there is newer version on clojars (I expected the instructions to be up to date).