yellow-294 / pe

0 stars 0 forks source link

DOCU BUG: delappt #15

Open yellow-294 opened 2 years ago

yellow-294 commented 2 years ago

I don't quite understand the point of showing 2 different Johns in ur delappt command. Instead I think it would be more meaningful to show me a before and after deleting the appointment

Screenshot 2022-11-11 at 5.31.12 PM.png

nus-pe-script commented 2 years ago

Team's Response

Thank you for your suggestion, the intention of adding multiple Johns is to showcase that the delappt command uses the index of the patient to delete the most recent past appointment. As we believe that this issue does not affect the readability of the UG, as our command is described well, we shall be rejecting this bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: "Thank you for your suggestion, the intention of adding multiple Johns is to showcase that the delappt command uses the index of the patient to delete the most recent past appointment."

The fact that you have to explain this to me for me to understand means your UG has not done a good job of showing this.

Also, I don't believe having 2 johns in the screenshot is needed to help me understand that the command is performed on the inputted index

You also did not address my 2nd issue regarding putting the before and after

The purpose of screenshots is to depict to me what the behaviour is of your command. You should be aware that the your UI has a small font and MANY different details. Because you have only put one screenshot, I am not sure where to look at.

Im not sure if this is even the before or after of the command until I saw the small "Past appointment deleted for John Doe" at the bottom

I don't even know where to look to see that the appointment has indeed been deleted.

This greatly affected my understanding of your command, and quite frankly, I felt could have even been a higher severity. Therefore I feel that the severity of VeryLow is more than reasonable.