Wal Calculation Fix - Githubissues

yellowbean / Hastructure

ABS/MBS cashflow engine written in Haskell, with API to Python and C/Java (on the way)

https://deal-bench.xyz

Other

15 stars 4 forks source link

Wal Calculation Fix #152

Closed yellowbean closed 5 months ago

yellowbean commented 6 months ago

remove duplication code There is a new function included : calcWalBond https://github.com/yellowbean/Hastructure/blob/2d4dadf84e935e7e426cb9dbc27980049052225f/src/Liability.hs#L223C1-L223C13

But there is the duplication of WAL calculation: https://github.com/yellowbean/Hastructure/blob/2d4dadf84e935e7e426cb9dbc27980049052225f/src/Liability.hs#L188

The code above should be replace by the calcWalBond function

calculation of cutoff balance can be optimized: https://github.com/yellowbean/Hastructure/blob/2d4dadf84e935e7e426cb9dbc27980049052225f/src/Liability.hs#L170