search

yellowbluesky / PixivforMuzei3

Best Pixiv plugin for Muzei 3
GNU General Public License v3.0
176 stars 15 forks source link

Filters not work #124

Closed linsui closed 3 years ago

linsui commented 4 years ago

I'm not sure but it seems that some filters don't work anymore in 3.1.2. I set the ratio filter to Portrait but some wide images slide in, e.g. https://www.pixiv.net/artworks/83386137 and https://www.pixiv.net/artworks/83361169. More manga than before slide in when I disable it. Maybe the NSFW filter is also broken.

yellowbluesky commented 4 years ago

Thanks for letting me know about this

I'll try to work on this over the weekend

BTW, those are some nice artworks

yellowbluesky commented 4 years ago

I'm looking at this issue now

linsui commented 4 years ago

Thanks!

Kyle2142 commented 3 years ago

Based on title I'm commenting rather than creating new issue: include/exclude manga option does not seem to make a difference. Another similar open source app on play store seems to implement this well. It's nice that we can delete them now, but obviously we'd prefer to not get them in the first place. I am using daily ranking, if that matters

yellowbluesky commented 3 years ago

I really can't answer why more manga shows up in my app that other apps.

There's only one flag that sets whether or not an image is manga; illust_type for Ranking, and type for Feed.

I'm very very sure I've got the logic correct.

I've looked at the meatdata for managa images that slip through, and they all have their manga flags incorrectly set.

linsui commented 3 years ago

It seems that the problem is not about manga but the whole filter. The NSFW filter and Portrait filter also don't work anymore. Here is a manga that slip through, could you please check it? Thanks!

yellowbluesky commented 3 years ago

When you say NSFW filter doesn't work, on what mode are you talking about? Rankings, Feed, or both?

linsui commented 3 years ago

Daily ranking. E.g., no matter I set the filter to SFW or NSFW I can see this one. https://www.pixiv.net/member_illust.php?mode=medium&illust_id=86361285

yellowbluesky commented 3 years ago

Hi Linsui

image I've confirmed manga filtering to be working now https://www.pixiv.net/en/artworks/86344083

image I've also confirmed that NSFW filtering to be working. https://www.pixiv.net/en/artworks/86361285

I'll test some more things out, then I'll it out as a new build.

Thanks @Kyle2142 and @linsui for helping and persisting in providing feedback.

linsui commented 3 years ago

Thanks!

yellowbluesky commented 3 years ago

I've pushed 3.1.4 out into release.

I've corrected a number of logic errors that were rejecting valid images (NSFW levels), and letting in invalid images (manga).

Again, thanks to you two, for getting me back into programming. I was feeling a bit burnt out from work and programming in general, now I'm getting back I'm genuinely enjoying it again :D

Let me know how this release works for you

linsui commented 3 years ago

It works perfectly! Thanks! The aspect ratio fileter alse works well! I guess I can close this issue.