search

yellowbluesky / PixivforMuzei3

Best Pixiv plugin for Muzei 3
GNU General Public License v3.0
174 stars 15 forks source link

Bug: Some partial-downloaded artworks is saved in storage #151

Closed KawaiiZapic closed 7 months ago

KawaiiZapic commented 3 years ago

For network reason, sometime artworks cannot download completely.
But these partial-downloaded images will be keep in storage, not delete or continue to download.
And they will not appear in images list in Muzei,just like is not existed.

P.S: I enabled save to public storage and auto copping image, I can't ensure cause this by them or not.

A partial-downloaded artwork

yellowbluesky commented 3 years ago

What version of Android are you on?

I know exactly what is causing this issue, I had it fixed earlier, but I disabled it again out of laziness.

However, if you're on Android 10 or higher you're going to have to live with it for a little bit until I put some time into fixing this, I'm afraid

misternem0 commented 2 years ago

I have this issue as well from time to time. I have it set to download 3 images at a time, and the images (from bookmarks) rotate once per hour. I will see partially downloaded images perhaps once or twice every day or two.

Navixer commented 7 months ago

Screenshot_20240131_113911_Gallery It's getting worse. Almost all recently downloaded images are partial or corrupted. I'm on Samsung A52s One Ui 6.

yellowbluesky commented 7 months ago

Thanks for sending through a other issue report

This is being worked on tracked in issue #199.

A fix is close to release actually, I am just ironing out one last bug with the implementation.

If possible, can you please send me samples of two or three corrupted images?

Part of the difficulty in fixing this issue is that I cannot replicate this issue from my location (Central Europe)

Navixer commented 7 months ago

Here you go. I archived them so they aren't modified. Thanks for working on it, I really appreciate it.

yellowbluesky commented 7 months ago

Actually, can you please try this test build and let me know how well it works for you?

https://github.com/yellowbluesky/PixivforMuzei3/releases/tag/3.1.7-alpha

This will install a new app and new Muzei source that must be selected.

Navixer commented 7 months ago

Okay I will try and report back soon.

Navixer commented 7 months ago

Now it saves a 0 byte empty file. When I turn on the save to storage setting the app can't fetch any pictures (it gets files but they are empty and can't apply them)

When I turn the setting off it correctly gets pictures and applies them but ofc now there are no saved pics.

yellowbluesky commented 7 months ago

The other user reported a similar issue to you.

Can you please tell me what Android version and skin your phone is running?

Navixer commented 7 months ago

Android 14. Samsung One UI 6. There is no skin, I only have a font. The bug has been here for a long time I don't think it's related to customization. It was here on android 13 and One UI 5 too. I also use Good Lock (home up etc.) I have just reverted the font to original and the same thing happens. Empty images (dev version).

yellowbluesky commented 7 months ago

Can you please try this build and let me know if you have any issues with it.

https://github.com/yellowbluesky/PixivforMuzei3/releases/tag/3.1.7-alpha2

After uninstalling and reinstalling my app, I was able to replicate your issue of not being able to save into external storage. Turns out the issue was a very simple one and entirely my fault.

Navixer commented 7 months ago

It seems like everything is fixed! It properly saves now and there is no partial or corrupted images. I tried it with 10 images no issues so far. Don't worry about it, thanks for the good work.

yellowbluesky commented 7 months ago

No worries, I'm happy to help my users :)

I'll close this issue now. When the fix gets merged into the production version on Google Play or Fdroid I will let you know here