search

yellowbluesky / PixivforMuzei3

Best Pixiv plugin for Muzei 3
GNU General Public License v3.0
174 stars 15 forks source link

Problem in sharing artwork #157

Closed KawaiiZapic closed 2 years ago

KawaiiZapic commented 3 years ago

Using "Share" button in Muzei does not pass a correct path to app. save to public storage is enabled.
I can't catch any logs to give any information about this problem,I think this problem is caused by the removing of duplicate artwork in somewhere else and providing a not existed path to Muzei.

yellowbluesky commented 3 years ago

Thanks for bringing this to my attention. I'll have a look in the next few days.

KawaiiZapic commented 3 years ago

I spent some time to take a research on this feature, and I found that is not just a file path passing bug.
I think there is a freaking mess in the code of storage.

The "clean cache" button will not clean /data/data/com.antony.muzei.pixiv/cache,just clean /sdcard/Android/data/com.antony.muzei.pixiv,and after switch to next artwork,the old picture will still keep a copy in /data/data/com.antony.muzei.pixiv/cache/muzei_com.antony.muzei.pixiv.provider.
If enable save artwork to public storage,the provider will not pass a correct file to other apps.

It's too mess.

yellowbluesky commented 3 years ago

Thanks for taking the time to do your own research / investigation

I've been tremendously busy with other things, I'll try to slot some time in to fix this

You are more than welcome to pull request a fix if you find one :)