Downloader is going haywire and downloading the same image multiple times

[biomatter]

Please see attached image as an example. This only started happening within the last few days. The image previewer in the app does not show the duplicates, hiding the problem

[yellowbluesky]

Hi there,

What version of Android are you using, and are you storing into external storage?

I had completely refactored the image downloading and sharing code for the last update, so there must be something that I messed up somewhere

[biomatter]

I'm on Android version 10. This is not external storage. Thanks for being so fast, I really like the app

[yellowbluesky]

This is more for my curiosity, but can you please try setting each duplicate to be your wallpaper and then check if the same wallpaper is applied each time? Muzei sometimes bugs out its thumbnails, perhaps causing the issue you are having now.

Do you have the cache set to clear every day? If not, can you please try clearing the cache and then report back to me again tomorrow?

I am not sure why this issue has started happening recently / after the latest app update. The code that handles duplicate image detection was not touched, and has not been touched for many months now.

EDIT: I'm glad you like my app 😊 Please suggest any features you would like to see

[biomatter]

Those aren't muzei thumbnails, that was a view from a photo viewing app. The duplicates were real, essentially.

I don't have it set to clear cache. Will that delete the contents of the folder?

[yellowbluesky]

Yes, clearing the cache (etiher by pressing the button on the Main tab or by enabling the automatic option) will clear all the images you have in there.

FYI, note that because you are not storing into external storage, the Android system may clear that folder at any time if it feels like it needs to reclaim space. This is dependent on how much remaining space you have left on the storage

I have a theory on why the duplicates are appearing:

• I did make some changes to how file extensions are assigned to image files, previously they were all hardcoded to .png out of laziness.
• Because I am now correctly applying file extensions, we can expect to see up to two duplicates of a single image: XX.png and XX.jpeg

However, this theory doesn't hold water:

• If you say that the cache was never cleared, then the code should not have gotten up to the point of image downloading at all
• This doesn't explain how there are four duplicates of the pink haired girl.

[biomatter]

Sorry, I was wrong... It is duplicates being saved into external storage, not the cache. I didn't understand the difference and thought that the pixiv folder was the one the app used. My bad :(