Update DNS for China - Githubissues

yellowbluesky / PixivforMuzei3

Best Pixiv plugin for Muzei 3

GNU General Public License v3.0

173 stars 15 forks source link

Closed UjuiUjuMandan closed 3 months ago

UjuiUjuMandan commented 3 months ago

Your DoH request is not correctly build according to docs. Just use OkHttp's native DoH client.
Old IPs in RubyHttpDns are outdated and can no longer provide www.pixiv.net, I replaced them with query results of pixiv.net (no www prefix!).
~~Add SNI bypass to LoginActivityWebview with shouldInterceptRequest.~~

UjuiUjuMandan commented 3 months ago

@yellowbluesky Do you use Android Studio? I don't know why Logcat is always blank...

UjuiUjuMandan commented 3 months ago

Let me leave WebView SNI bypass to the future...

yellowbluesky commented 3 months ago

I will review this in a day or two, I'm super busy at the moment

Thank you for you patience!

yellowbluesky commented 3 months ago

Without revealing too much, are you located in a region where the Great Firewall is in effect?

I live in Europe, so I am not able to test the functionality of your changes.

UjuiUjuMandan commented 3 months ago

Without revealing too much, are you located in a region where the Great Firewall is in effect?

Yes, I am, and these changes are actually for my personal use.

UjuiUjuMandan commented 3 months ago

I live in Europe, so I am not able to test the functionality of your changes.

You can not test the functionality but can test the disfunctionality before.

For DoH, use PCAPdroid to decrypt HTTPS and you’ll observe 400 bad request in response.

For SNI bypass, just switch it on and everything won’t work at all because www.pixiv.net can not be reached at that outdated IP.

yellowbluesky commented 3 months ago

I've merged your PR into the master, thank you for your contributions.

Before I push this change to production, would you like to be credited in my app as a contributor?

UjuiUjuMandan commented 3 months ago

Before I push this change to production, would you like to be credited in my app as a contributor?

Edit: It's OK if I'm in release note, but not in app, it seems a little crowded there.