search

yellowbluesky / PixivforMuzei3

Best Pixiv plugin for Muzei 3
GNU General Public License v3.0
176 stars 15 forks source link

Move networking functions into own file #43

Closed yellowbluesky closed 4 years ago

yellowbluesky commented 4 years ago

Something like this is good

https://github.com/upbit/pixivpy/blob/4ec64921bbf2d00e9e46afc5cecf128020b2586a/pixivpy3/aapi.py#L273

https://github.com/upbit/pixivpy/blob/4ec64921bbf2d00e9e46afc5cecf128020b2586a/pixivpy3/aapi.py#L27

https://github.com/upbit/pixivpy/blob/4ec64921bbf2d00e9e46afc5cecf128020b2586a/pixivpy3/api.py#L59

yellowbluesky commented 4 years ago

yeah currently it's a mess, with many functions doing very similar things

First I'll consolidate the networking code, clean it up and move them back into the caller functions

Then I'll move them out into their own file cleanly

This way will allow me to work on it bit by bit

yellowbluesky commented 4 years ago

Good progress made as of 097658711957fe0198a811e96c390a4c8db0438a

yellowbluesky commented 4 years ago

finalised in 097658711957fe0198a811e96c390a4c8db0438a