Correct bugs in Zone and Rectangle

yellowstonegames / SquidLib

Useful tools for roguelike, role-playing, strategy, and other grid-based games in Java. Feedback is welcome!

Other

448 stars 46 forks source link

Correct bugs in Zone and Rectangle #185

Closed smelc closed 6 years ago

smelc commented 6 years ago

The one in SquidIterators.RectangleFromBottomLeftToTopRight, which was affecting Rectangle::getAll's method (on which a lot methods of Zone's default implementations rely) when coords were on the edge of the dungeon (y == 0) or negative was pretty serious and hard to track.

tommyettinger commented 6 years ago

Ooh, merging... Do you have any ideas on what to do about 1.6/1.7 compatibility and Android? It could be pretty rough to make this fully 1.6-compatible; I think there's some important methods that are supported on most Android versions (and GWT) but not Java 6.

smelc commented 6 years ago

I didn't build for Android since almost a year now, so I cannot speak about API compatibility :-( Regarding compiler compatibility with 1.6, I've seen that some code use diamond operators; but I think it could be corrected; it was circa a few hundred errors.