search

yellowtides / owenbot-hs

A utility bot written in Haskell for the Edinburgh Informatics Class of ‘24’s main messaging platform (Discord server).
https://yellowtid.es/owenbot-hs/
BSD 3-Clause "New" or "Revised" License
8 stars 7 forks source link

Inconsistency with regex handling. #13

Closed social-anthrax closed 3 years ago

social-anthrax commented 3 years ago

All commands should be handled within Command Handler, with some exceptions for the random rolling functions. However isFortune, isADA, isThatcher and isNietzsche are all residing within handleEvent.hs making it extremely cluttered.

These should be migrated to CommandHandler.

yellowtides commented 3 years ago

True, haven't considered that we'd get to the point of having so many miscellaneous functions. I think that we should have a seperate miscellaneous folder with all the misc. functionality/REs. Files like ADAPriceFetcher.hs should also be moved there.

social-anthrax commented 3 years ago

As it stands it should be easy for them to be moved straight into the command handler file without any loss of functionality. The files that should be allowed to be there are the ones to do with rolling and random chance.