search

yellowtree / geoip-detect

Wordpress plugin "Geolocation IP Detection": Provides geographic information detected by an IP adress.
http://wordpress.org/plugins/geoip-detect/
GNU General Public License v3.0
163 stars 38 forks source link

Bugfix: Cloudfront header rename #214

Closed abidhahmed closed 1 year ago

abidhahmed commented 1 year ago

Hi! This is a great plugin, thank you so much for your efforts. I've been trying it out on one of our cloudfront enabled websites and noticed the plugin not working (we also tested it in Cloudflare which works nicely) -- turns out the header simply isn't correct, and I was able to get it working after supplying the correct format.

Hence the PR, which I believe also fixes this report from some time ago > https://wordpress.org/support/topic/special-hosting-providers-aws-cloudfront-option-dont-work/

Thanks again!

benjaminpick commented 1 year ago

Thank you for this fix, I will merge it for the next version of the plugin.

Do you think this could break other sites relying on the old header name? I.e., does this depend on Cloudfront configuration, or was the old header name simply wrong/outdated?

(BTW, I have started developing the auto-update of the reverse proxy list! I will ping you when it's ready for beta-testing.)

abidhahmed commented 1 year ago

Do you think this could break other sites relying on the old header name?

I can confidently say it never worked before in my tests and we've had it running now for over 3 months with the fix and all's good so far.

Please feel free to test on your end before releasing the fix. :)