search

yemM / flippy

Flippy is a cross-browser flip effect plugin for jQuery which allows you to flip whatever html element you want. It now supports rgba colors
140 stars 98 forks source link

Take out the background color. #30

Open ghost opened 10 years ago

ghost commented 10 years ago

Hey, I think you've made a great plugin, I don't understand why you have a background color property. I just wanted to flip a png image and swap it with another one. Why are you forcing there to be a background color? The flip still works with transparency. I ended up taking out several lines of code to make it work... The background color should be in the CSS, not taken charge with your plugin. Your plugin should only flip stuff.

Having said that, thanks for the plugin. It works and i'm happy with the results :)

ghost commented 10 years ago

Hey, Sure, i can tell you what I did. I can't find a copy of the modified script... I didn't end up using it, so I must of deleted it. However, it's not that hard, to do. Do a search for the word "color" and delete every line that has to do with it.

Let me know if it worked.

2014-01-30 pikaboul notifications@github.com:

Hi, Can you explain how you did it? I'm facing the same case.

Thank you, and thanks to the plugin author!

Reply to this email directly or view it on GitHubhttps://github.com/lepixel/flippy/issues/30#issuecomment-33744231 .

thomasboulongne commented 10 years ago

Your idea was simple, but incredibly efficient and it works like a charm! I still can't understand why the author implemented this color function... Thank you very much

ghost commented 10 years ago

Me neither. It's really has nothing to do with the original idea. He's got lots of code to support rgba colors on old browsers. Who cares! He also made it impossible to change the background color to transparent in your CSS.

Oh well, other than that, it's a good plugin!

Glad i could help. Le 3 févr. 2014 18:09, "pikaboul" notifications@github.com a écrit :

Your idea was simple, but incredibly efficient and it works like a charm! I still can't understand why the author implemented this color function... Thank you very much

Reply to this email directly or view it on GitHubhttps://github.com/lepixel/flippy/issues/30#issuecomment-34012110 .