remove torchsearchsorted dependency

yenchenlin / nerf-pytorch

A PyTorch implementation of NeRF (Neural Radiance Fields) that reproduces the results.

MIT License

5.49k stars 1.06k forks source link

remove torchsearchsorted dependency #10

Closed Nikronic closed 4 years ago

Nikronic commented 4 years ago

Hi, To remove aforementioned dependency, PyTorch built-in method has been used. Although, it has a small bug which can be resolved by detaching tensors with grad as the output of torch.searchsorted is int so it does not have gradients.

Also, the readme has been updated regarding this change, and a typo has been fixed.

Furthermore, I added my experience with model for training on fern dataset (time wise).

yenchenlin commented 4 years ago

Awesome contribution, thanks 🎉 ! Merged.