yenom / BitcoinKit

Bitcoin protocol toolkit for Swift
MIT License
842 stars 262 forks source link

Compact 65-byte signature #205

Open hoanglu14 opened 5 years ago

hoanglu14 commented 5 years ago

What problem does this feture solve?

I couldn't find any function to support compact signature (65 bytes: header + r + s) using this framework. This can be done if you guys also include secp256k1_recovery.h in BitcoinKitPrivate. Then, I can just simply make my own compact signature with secp256k1_ecdsa_recoverable_signature_serialize_compact

I also cloned this project and tried to do what I said above. However I ran into a compile error saying

I have no idea why so a little help would be very appreciated.

usatie commented 5 years ago

@hoanglu14 Sorry for my late reply. Your suggestion is good. That feature should be implemented in the future.

Also, can you give me more information about the compile error?