search

yeo-yiheng / pe

0 stars 0 forks source link

Edit user email does not check for duplicates #4

Open yeo-yiheng opened 2 years ago

yeo-yiheng commented 2 years ago

Again, editing of the user does not check for duplicate email / number. I have attached the example for email only for reference as number is replicated similarly.

edit email.png

nus-pe-script commented 2 years ago

Team's Response

This should be an obvious duplicate of #2575. Nevertheless, to elaborate, ensuring that email addresses are unique must mean that:

  1. a user cannot add a duplicate email address
  2. a user cannot make a change that causes a duplicate email address (edit)

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding students with the same email

I am able to add students with the same email, though all emails should be unique as well.

same email.png

[original: nus-cs2103-AY2122S1/pe-interim#2638] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Firstly, this is the expected behavior of our app so it should not be considered as a FunctionalityBug. What the tester seems to be proposing is that there should be a feature that catches duplicate emails, so we have relabeled this as a feature flaw (i.e. missing feature). Furthermore, it is expected to be extremely unlikely that our target users (1-1 private home tutors) mistakenly type the same email for 2 students, so there is very little harm done by not including this feature of detecting duplicate emails within our app. Therefore, it should not be of medium severity.

More importantly, the omission of this feature does not make the app any less useable for our TA. It might even be beneficial.

...all emails should be unique...

This StackOverflow post explains why it may not be correct to make this assumption. While email addresses are typically unique, it is not impossible for them to be shared. It is possible for multiple individuals to use the same email address. It is more reasonable that our TA expects that some family members may share an email address. We appreciate the suggestion but we do not think what the tester brought up is a bug, as we think that the tester's expectation that our app should disallow duplicate emails seems to be mistaken.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Adding and editing a student with different emails is a different issue.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While it may be true that the odds of adding a similar email mistakenly might be low, it is not improbable as well. Suppose I am trying to add student A to the address book. I just started using TAB and have a huge list of student names and emails to import. However, I accidentally skipped a line down and added student B's email to student A. I then proceed to add student B correctly and so forth.

Fast forward to the day I actually need student A's email, I may be emailing student B instead since there was no warning that the email was a duplicate.

While it may be probable that there exist students sharing the same email, the odds are extremely slim since email creation is free and usually personal. This added level of check will not prove fatal for the application and serves to prevent the user errors more often than not. In addition, I appreciate the StackOverflow thread. However, this is also not an organization and reuse of emails is highly unlikely.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]