yeo-yiheng / pe

0 stars 0 forks source link

Adding past dates #5

Open yeo-yiheng opened 2 years ago

yeo-yiheng commented 2 years ago

Adding of classes allowed adding of past dates e.g. year 1945

adding past years.png

soc-se-bot commented 2 years ago

Team's Response

This issue is similar to allowing past dates to be added for a lesson (#4034) as it also involves keeping a past record of the lesson. The tester seems to imply that keeping a past record of lessons that are completely over should not be allowed. However, this is the intended function of our application and hence we classify this as a duplicate of issue #4034 and should be a feature flaw since this is indeed how we intended our app to behave.

Refer to #4034 for further justification on why we intended our app to behave this way.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Can add past date in add lesson

When adding lessons, it doesn't make sense when a start date is a past date. I think that this should be documented in the UG that you can add past lessons.


[original: nus-cs2103-AY2122S1/pe-interim#4101] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

In the UG, it was stated that the purpose of our app is to help users keep track of all their lessons. A tutor who has just started using TAB may want to add an existing lesson that has already started in the past. Therefore, the expected behaviour of the app is to allow the user to add all of their lessons, regardless of whether it has passed. This is the intended behaviour.

This can also be seen from example 2 in the screenshot provided below, where we allow the user to keep past records of their lessons. Recording past lessons are not intended to be treated as invalid inputs as it remains a fact that the user might have had this lesson before and wants to keep a record of it.

However, we acknowledge that lessons with dates in the distant past (more than 100 years ago) should not be allowed to be added. However, it is highly unlikely that users would do so unless they are not using the app for its intended purpose. If they accidentally keyed in the wrong date, they can always edit it so it is not a problem and the app is still very much usable. Hence, we consider this out-of-scope for our project.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I still strongly feel that adding past dates is a possible hindrance to the user. The fact that our past dates will be automatically added to the top of the lesson panel is quite hard to work with.

Suppose I want to keep a record of all my past lessons, and I have a student that has taken over 50 lessons with me already. That would mean that these 50 lessons will be the first 50 lessons on the list. In order for me to see what other lessons this student has, I have to scroll down past all 50 lessons, which is quite a hindrance.

I think that while it is a great idea to keep track of past lessons as substantiated, it does in fact hinder the user's ability to use the application properly and smoothly with all these lessons cluttering the lesson panel.

With that, I would like to revise my initial severity of severity.LOW to severity.MEDIUM.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: I should be able to easily view the lessons but these past dates lessons are obstructing my workflow from being efficient.