yeo-yiheng / pe

0 stars 0 forks source link

No week 1 for weekly calendar #8

Open yeo-yiheng opened 2 years ago

yeo-yiheng commented 2 years ago

Likewise no week 1 for weekly calendar

caclendar week.png

nus-se-bot commented 2 years ago

Team's Response

The tester is mistaken that this is the weekly calendar. It is actually the monthly calendar. Probably just a typo.

Regardless, the problem is that week 1 of 2022 is also week 53 of 2021.

image.png

In our opinion, it is easier to infer that the year starts a week before the second week than that a year ends on the first week of the next year because that would actually make the following example extremely confusing as the user would incorrectly expect that 2022 ends at week 1

image.png

We feel that it is not within the scope of our project to address these technical conventions, and it is impossible to change this due to it being a CalendarFX constraint. The UI is clear enough for any function and references.

This is labeled as a duplicate issue of #2692 as there is no way to fix this and #2692 independently of each other, i.e., we MUST change the week number of the year calendar if we change the week number of the month calendar.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Yearly calendar has no week 1

There is no week 1 in yearly calendar

calendar year.png


[original: nus-cs2103-AY2122S1/pe-interim#2645] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The tester is mistaken that this is the weekly calendar. It is actually the monthly calendar. Probably just a typo.

Regardless, the problem is that week 1 of 2022 is also week 53 of 2021.

image.png

In our opinion, it is easier to infer that the year starts a week before the second week than that a year ends on the first week of the next year because that would actually make the following examples extremely confusing. Suppose that December 2021 shows weeks 52, 1, 2, the user would incorrectly expect that 2021 ends at week 52.

image.png

image.png

We feel that it is not within the scope of our project to address these technical conventions, and it is impossible to change this due to it being a CalendarFX constraint. Furthermore, the UI is clear enough for any function and references.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: "In our opinion, it is easier to infer that the year starts a week before the second week than that a year ends on the first week of the next year because that would actually make the following examples extremely confusing. Suppose that December 2021 shows weeks 52, 1, 2, the user would incorrectly expect that 2021 ends at week 52."

I disagree with this. This is up to each individual user's interpretation of the calendar. From my viewpoint, I find it more intuitive to know when the first week of my next year starts as opposed to seeing it a week before. Perhaps a middle ground could be a 53 / 1 to indicate that it is week 53 of the previous year but week 1 of the upcoming year. However, I get that this may be due to the limitation of the API your team has integrated. Perhaps there should be an added feature / documentation to explain this particular feature kink to the users in case some might find it confusing?

E.g. A popup window to highlight the reason for the jump from week 53 to 2.