yeo / ec2.shop

fastest way to check and compare ec2 and other aws service pricing
https://ec2.shop
MIT License
112 stars 17 forks source link

New fields: Spot Savings, Spot Reclaim Rate #9

Closed Pluies closed 4 months ago

Pluies commented 4 years ago

Hi again @v9n 😄

This time it's for new functionality: get the savings & reclaim rate for spot instances!

A bit of background – I wanted a way to compare spot prices vs. their reclaim rate. The data is available in various places, but never side-by-side (ugh), so I decided to patch it all up together here.

I'm not sure this is something you'd like to incorporate in ec2.shop itself, as it may start to make things a bit cramped, but I thought I'd send a PR anyway if this is of interest 👍

Here's a screenshot of the feature in action:

Screenshot 2020-07-10 at 12 14 50
v9n commented 4 years ago

@Pluies

This is great.

This add more feature so give me sometime to review and test it. But definetely useful to have. That's the whole purpose of this UI, right? To save us time going to the crunchy AWS pricing page :-).

I think I'm going to merge this in. But are you able to add a checkbox that say sth like this

And we hide those saving columns by default. Because I plan to add reserver pice and this is getting croweded 🗡️

Pluies commented 4 years ago

@v9n all done! New checkbox "Show Spot data", that toggles whether to show just the basic info or basic info + Spot price / Spot savings / Spot reclaim rate 👍

I'm not a huge fan of the implementation I've written, as it duplicates the window._pricedata array, but I'm not sure of a better way to go there 🤷

v9n commented 4 months ago

Hi @Pluies After so many years and more use on Spot I think this is useful. I will rebase and getting this to our release.

v9n commented 4 months ago

Hi @Pluies This is implemented. Thank you so much for your initial PR.

v9n commented 4 months ago

@Pluies Because I don't use this PR directly I add a credit section on the REDME:https://github.com/yeo/ec2.shop?tab=readme-ov-file#spot-saving-and-spot-reclaim