search

yeohhq / pe

0 stars 0 forks source link

Command: 'addlsn' lesson number restriction to only take single digit #2

Open yeohhq opened 3 years ago

yeohhq commented 3 years ago

This issue reports a feature flaw/suggestion where I believe it would be logical to accept a larger range of values for the lesson number for 'addlsn' command.

Input: addlsn grp/g04 lsn/00-10

Output: Screenshot 2020-11-13 at 4.30.33 PM.png

Rationale: For the lesson number, perhaps it should be able to accept numbers with more than one digit (e.g. if the tutor is conducting multiple lesson throughout the current week for different teams).

nus-se-bot commented 3 years ago

Team's Response

unclear what does 'different teams' means but assuming that it is referring to different tutorial groups. Each tutorial group is a single tutorial class, i.e. ~20 students. The number at the back denotes the lesson number of the week, e.g. 1-2 indicates lesson 2 of week 1. It may be logical to allow larger range of values for lesson number, but it is unrealistic for a single tutorial group to have more than 10 tutorial in a week.

Mentioned in UG

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]