search

yeohhq / pe

0 stars 0 forks source link

Able to 'unflag' a student that was not 'flagged' #7

Open yeohhq opened 3 years ago

yeohhq commented 3 years ago

Original state: Aaron is already present, hence 'flagatt 1' does not 'flag' him out. (i.e. he is not 'flagged') Screenshot 2020-11-13 at 5.04.44 PM.png

Input: unflagatt 1

Output: Aaron was unflagged despite originally not being flagged, and his attendance has also changed to 'absent', not sure if this was the intended use of 'flag'?

Screenshot 2020-11-13 at 5.05.33 PM.png

Reference: Screenshot 2020-11-13 at 5.07.37 PM.png UG description suggests that you should only be able to unflag a student that was successfully 'flagged'.

nus-se-bot commented 3 years ago

Team's Response

Definition of

severity.High : A flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users.

This bug does not cause our product to become unusable.

severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

If you followed the workflow of our UG, and based on the intuitiveness of the command (unflagatt naturally comes after flagatt), this bug is unlikely to be picked up during normal usage.

If and when this bug does occur to the user, the user can simply do markpresent INDEX again.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]