search

yeojz / metalsmith-react-templates

A metalsmith plugin to render files using React / Preact / JSX based templates.
MIT License
92 stars 17 forks source link

nonStatic #8

Closed woodyrew closed 9 years ago

woodyrew commented 9 years ago

Could I suggest renaming nonStatic to static or isStatic and having an alias called nonStatic for backwards compatibility? Negated boolean variable names can cause unnecessary confusion. e.g.

if (nonStatic === false) {...} 
\\ or
if (isStatic === true) {...}

I'm happy to fork and do a pull request? Excellent plugin apart from that.

yeojz commented 9 years ago

@woodyrew good point. I agree... let's put it as isStatic.

PR definitely welcomed :+1:

Thanks!

woodyrew commented 9 years ago

Added PR #9

yeojz commented 9 years ago

Closed via #9