yeoman / bower-requirejs

[DEPRECATED] Automagically wire-up installed Bower components into your RequireJS config
375 stars 68 forks source link

Fixes #89 Modules that support both AMD and node use node #90

Closed abrenneke closed 10 years ago

abrenneke commented 10 years ago

This fixes the issue for #89. Again couldn't write tests because the upstream tests are failing for me for some reason.

Craga89 commented 10 years ago

:+1: Affected by this as well, be grateful if this could be fixed soon!

robdodson commented 10 years ago

See #93 I want to make sure there are tests for these changes before we can merge them

bezoerb commented 10 years ago

There is also the issue, that packages are added to the config every time we run the task instead of overwriting the existing one which results in a rjsConfig config file like this:

require.config({
    shim: {

    },
    paths: {
        jquery: "jquery/dist/jquery"
    },
    packages: [
        {
            name: "picturefill",
            main: "dist/picturefill.js",
            location: "/Users/ben/Sites/Spielwiese/htdocs/test/bower_components/picturefill"
        },
        {
            name: "picturefill",
            main: "dist/picturefill.js",
            location: "/Users/ben/Sites/Spielwiese/htdocs/test/bower_components/picturefill"
        },
        {
            name: "picturefill",
            main: "dist/picturefill.js",
            location: "/Users/ben/Sites/Spielwiese/htdocs/test/bower_components/picturefill"
        },
        ...
    ]
});
bezoerb commented 10 years ago

@robdodson what about this one?

bezoerb commented 10 years ago

@robdodson think it would have been cool to merge that in ;) Even if modules like picturefill or knockout should work after https://github.com/yeoman/bower-requirejs/pull/97 it would be nicer if they were referenced as amd

robdodson commented 10 years ago

Sorry I thought this was addressed by a previous PR. Feel free to merge if you think it looks OK

bezoerb commented 10 years ago

@SneakyMax thanks for working on this

bezoerb commented 10 years ago

@robdodson what about npm? Should i publish a new version too or am i lacking the required rights

robdodson commented 10 years ago

Just published it and pushed a new tag. Thanks!

On Thu, Sep 11, 2014 at 7:48 AM, Ben Zörb notifications@github.com wrote:

@robdodson https://github.com/robdodson what about npm? Should i publish a new version too or am i lacking the required rights

— Reply to this email directly or view it on GitHub https://github.com/yeoman/bower-requirejs/pull/90#issuecomment-55274643.