search

yeoman / bower-requirejs

[DEPRECATED] Automagically wire-up installed Bower components into your RequireJS config
375 stars 68 forks source link

Only add packages once #96

Closed bezoerb closed 10 years ago

bezoerb commented 10 years ago

Fixes the issue mentioned in https://github.com/yeoman/bower-requirejs/pull/90#issuecomment-54107221

bezoerb commented 10 years ago

@sindresorhus @robdodson what about the general workflow for fixes like this? Should we stick with: a) generating pull requests and let someone else merge it to get the benefits of a four-eye principal and therefore minimize the chance of breaking something. or should we b) just pull in changes when travis is happy.

I think i would prefer the first approach. How do think about it?

robdodson commented 10 years ago

I'm happy to review and merge :) If you can make that one style tweak I'll get this in

bezoerb commented 10 years ago

style tweaked ;)

robdodson commented 10 years ago

OK, merged it in. Anything else you want to sneak in before 1.1.1 release?

bezoerb commented 10 years ago

No, thanks. I think i'm fine with this one :)

robdodson commented 10 years ago

OK cool. I just pushed out v1.1.1

bezoerb commented 10 years ago

@robdodson npm still points to 1.1.0

robdodson commented 10 years ago

sorry about that, should be fixed now

On Wed, Sep 3, 2014 at 11:31 PM, Ben Zörb notifications@github.com wrote:

@robdodson https://github.com/robdodson npm still points to 1.1.0

— Reply to this email directly or view it on GitHub https://github.com/yeoman/bower-requirejs/pull/96#issuecomment-54414224.

bezoerb commented 10 years ago

:thumbsup: