search

yeoman / generator-backbone

Scaffold out a Backbone.js project
http://yeoman.io
638 stars 157 forks source link

Add `private` to `_package.json` #339

Closed arthurvr closed 9 years ago

arthurvr commented 9 years ago

Minor cleanup to _package.json and addition of private.

Ref https://github.com/yeoman/generator-gulp-webapp/commit/00f5422f97302c260acafab9b5edc9e34e6988bc and https://github.com/yeoman/generator-webapp/commit/f0e8d527f01d907cc31aef882c5de85b9b8bc037.

arthurvr commented 9 years ago

I first thought the test failures were unrelated but seems like that's not true. Looking into it.

addyosmani commented 9 years ago

The tests still appear to be failing on this one but not the others. Change otherwise looks like it would be fine, but would be good to dig into this further before we try landing.

arthurvr commented 9 years ago

Magically passing after rebasing. I guess https://github.com/yeoman/generator-backbone/commit/ce63ef227767d92c512ec76cd026015c84c84be9 fixed it. Allons-y!