search

yeoman / generator-backbone

Scaffold out a Backbone.js project
http://yeoman.io
638 stars 159 forks source link

Updated yeoman-generator dependency to v0.20 #356

Closed ruyadorno closed 8 years ago

ruyadorno commented 8 years ago

Updated the yeoman-generator to use the v0.20+ API

ping @arthurvr

arthurvr commented 8 years ago

Hey @ruyadorno! Thanks for this PR! Looks neat! I'm about to leave for 2 weeks so can't review this but I'll get back to you. Sorry!

ruyadorno commented 8 years ago

thanks for letting me know @arthurvr! meanwhile, any news on the new maintainers?

ruyadorno commented 8 years ago

@revathskumar I've seen you're catching up with the new APIs, feel free to help with the code review too :blush:

arthurvr commented 8 years ago

Thanks for the PR!

Can we also update the templates to use the new -%> trick? There are some files where that would be handy (_bower.json just to name one)

addyosmani commented 8 years ago

Can we also update the templates to use the new -%> trick? There are some files where that would be handy (_bower.json just to name one)

:+1:

ruyadorno commented 8 years ago

:+1: Updated with all suggested fixes

ruyadorno commented 8 years ago

ping @arthurvr

arthurvr commented 8 years ago

Me likey! No reason to start doing ping comments after 10 hours though. I don't have the bandwidth to review big PRs daily :p

ruyadorno commented 8 years ago

heheheh my bad, I just wasn't sure if you got the notification, didn't meant to pressure though, only arrived at work had the PR page still open and thought "oops, I should have pinged his username on the first message just to be sure"

arthurvr commented 8 years ago

@ruyadorno No worries :p

ruyadorno commented 8 years ago

@arthurvr fixed the trailing commas on Gruntfile :+1:

tconroy commented 8 years ago

this gonna be merged in?

arthurvr commented 8 years ago

this gonna be merged in?

Sure! Why not?

arthurvr commented 8 years ago

Super-duper work @ruyadorno!

tconroy commented 8 years ago

:+1:

ruyadorno commented 8 years ago

:confetti_ball: