Closed ruyadorno closed 9 years ago
Hey @ruyadorno! Thanks for this PR! Looks neat! I'm about to leave for 2 weeks so can't review this but I'll get back to you. Sorry!
thanks for letting me know @arthurvr! meanwhile, any news on the new maintainers?
@revathskumar I've seen you're catching up with the new APIs, feel free to help with the code review too :blush:
Thanks for the PR!
Can we also update the templates to use the new -%>
trick? There are some files where that would be handy (_bower.json just to name one)
Can we also update the templates to use the new -%> trick? There are some files where that would be handy (_bower.json just to name one)
:+1:
:+1: Updated with all suggested fixes
ping @arthurvr
Me likey! No reason to start doing ping comments after 10 hours though. I don't have the bandwidth to review big PRs daily :p
heheheh my bad, I just wasn't sure if you got the notification, didn't meant to pressure though, only arrived at work had the PR page still open and thought "oops, I should have pinged his username on the first message just to be sure"
@ruyadorno No worries :p
@arthurvr fixed the trailing commas on Gruntfile
:+1:
this gonna be merged in?
this gonna be merged in?
Sure! Why not?
Super-duper work @ruyadorno!
:+1:
:confetti_ball:
Updated the
yeoman-generator
to use the v0.20+ APImem-fs-editor
methodsejs
,mkdirp
,htmlWiring
ping @arthurvr