yeoman / generator-bootstrap

Yeoman generator for Bootstrap
http://yeoman.io
186 stars 40 forks source link

Bootstrap Sass Upgrade to twbs/bootstrap-sass #23

Closed AlJohri closed 10 years ago

AlJohri commented 10 years ago

Can we change

https://github.com/yeoman/generator-bootstrap/blob/master/app/index.js#L46

to use the official twbs/bootstrap-sass repository?

https://github.com/twbs/bootstrap-sass https://github.com/twbs/bootstrap-sass/issues/460 https://github.com/twbs/bootstrap-sass/pull/488

eddiemonge commented 10 years ago

Not yet apparently as the name change has not gone through. twitter-bootstrap-sass still points to:

bootstrap-sass git://github.com/jlong/sass-twitter-bootstrap
twitter-bootstrap-sass git://github.com/thomas-mcdonald/bootstrap-sass.git
bootstrap-sass3 git://github.com/blai/bootstrap-sass.git
bootstrap-sass-src git://github.com/h2non/bootstrap-sass-src.git
sass-bootstrap git://github.com/jlong/sass-bootstrap.git
sass-bootstrap-compass git://github.com/alademann/sass-bootstrap.git
sass-bootstrap-glyphicons git://github.com/greaterweb/sass-bootstrap-glyphicons.git
chosen-sass-bootstrap git://github.com/joeylomanto/chosen-sass-bootstrap.git
sass-bootstrap-theme-purple git://github.com/purple-dbu/sass-bootstrap-theme-purple.git

Perhaps it would be better to merge jlong/sass-bootstrap into twbs/bootstrap-sass? (https://github.com/twbs/bootstrap-sass/pull/488)

AlJohri commented 10 years ago

The https://github.com/thomas-mcdonald/bootstrap-sass version (which now redirects to twbs) was merged because it is converts 100% automatically allowing little room for error as the original twbs makes changes and upgrades.

Please see this thread: https://github.com/twbs/bootstrap-sass/pull/329#issuecomment-22367375

gauravverma commented 10 years ago

Now it's official : https://github.com/twbs/bootstrap-sass

addyosmani commented 10 years ago

Fixed by 3f07da820269a3c649509c1e22d290689487c0a8.