Open SBoudrias opened 8 years ago
does it include?
@udnisap sorry, what do you mean?
I am assuming you are referring to coverage.io reports. https://coveralls.io/builds/4282602 there are no templates
Oh, I'm talking about the generated code. I removed template coverage manually from this repository, but the generated code still covers the template folder.
It should be done at gulp-task?
gulp-coverall
doesn't provide any options to skip files.
in the pre-test tasks.
Just a '!**/templates/**'
is the src
is fine?
Well, I see specific files being mentioned in the src, no glob.
In the generated code, not the project code.
Ha ok, this change must be in 'node:app'
right?
Generate app has 100% coverage
Ha ok, this change must be in 'node:app' right?
I think this sounds right. Should this be closed here and opened there? https://github.com/yeoman/generator-node/issues/new
It'd probably require some changes on both sides, so we should keep it open here and figure how we want to pass that to generator-node (probably a new option).
Title is pretty self explicit. We don't want to cover JS files inside the template folder.