search

yeoman / generator-generator

Generate a Yeoman generator
1.22k stars 238 forks source link

Coverage should exclude the template folder #131

Open SBoudrias opened 8 years ago

SBoudrias commented 8 years ago

Title is pretty self explicit. We don't want to cover JS files inside the template folder.

udnisap commented 8 years ago

does it include?

SBoudrias commented 8 years ago

@udnisap sorry, what do you mean?

udnisap commented 8 years ago

I am assuming you are referring to coverage.io reports. https://coveralls.io/builds/4282602 there are no templates

SBoudrias commented 8 years ago

Oh, I'm talking about the generated code. I removed template coverage manually from this repository, but the generated code still covers the template folder.

hemanth commented 8 years ago

It should be done at gulp-task? gulp-coverall doesn't provide any options to skip files.

SBoudrias commented 8 years ago

in the pre-test tasks.

hemanth commented 8 years ago

Just a '!**/templates/**' is the src is fine?

Well, I see specific files being mentioned in the src, no glob.

SBoudrias commented 8 years ago

In the generated code, not the project code.

hemanth commented 8 years ago

Ha ok, this change must be in 'node:app' right?

udnisap commented 8 years ago

Generate app has 100% coverage

eddiemonge commented 8 years ago

Ha ok, this change must be in 'node:app' right?

I think this sounds right. Should this be closed here and opened there? https://github.com/yeoman/generator-node/issues/new

SBoudrias commented 8 years ago

It'd probably require some changes on both sides, so we should keep it open here and figure how we want to pass that to generator-node (probably a new option).