search

yeoman / generator-generator

Generate a Yeoman generator
1.22k stars 237 forks source link

replace nsp with 'npm audit --audit-level high' #228

Closed CodeLittlePrince closed 5 years ago

CodeLittlePrince commented 5 years ago

Recently, I can't publish my npm project which build with your generator: image I found that nsp causes this error. Besides, there is a vulnerability in nsp: image And, nsp has been deprecated: https://www.npmjs.com/package/nsp So, I spend a lot of time to find solution and find this: https://stackoverflow.com/questions/53716991/node-security-service-shutdown-getaddrinfo-enotfound-api-nodesecurity-io

SBoudrias commented 5 years ago

Thanks!

SBoudrias commented 5 years ago

This is breaking the CI right now:

npm ERR! audit Neither npm-shrinkwrap.json nor package-lock.json found: Cannot audit a project without a lockfile

We'll need to replace yarn by npm and add the package-lock.json

CodeLittlePrince commented 5 years ago

Sorry for no testing before, and I am confused that there is a error after I use npm link to the project I changed:

TypeError: superb is not a function at module.exports.writing (~/temp/generator-generator/subgenerator/index.js:25:17)

I'll close this PR at first.