search

yeoman / generator-gruntplugin

Create a gruntplugin module with yo, including Nodeunit unit tests.
http://yeoman.io
MIT License
35 stars 12 forks source link

Feature: package manifest standardisation #18

Closed ain closed 10 years ago

ain commented 10 years ago

According to package.json-validator the generated manifest file has incorrect licence and repository fields:

  1. Licence has no URL to the licence file (could be a dummy URL that can be fixed later);
  2. Repository is a string (e.g. "repository": "https://github.com/yeoman/generator-gruntplugin") instead of an object:
"repository": {
  "type": "git",
  "url": "https://github.com/yeoman/generator-gruntplugin.git"
},
sindresorhus commented 10 years ago

That validator is wrong. Both are allowed.

We adhere to https://github.com/npm/read-package-json

ain commented 10 years ago

NPM docs document repository field as an object, but license as a string. Looks like a bit too much of a confusion there.