Complete rewrite of the generator

yeoman / generator-karma

Yeoman generator for Karma

http://yeoman.io

BSD 2-Clause "Simplified" License

172 stars 48 forks source link

Complete rewrite of the generator #51

Closed eddiemonge closed 10 years ago

eddiemonge commented 10 years ago

Goals:

Use the new 0.17.0 Yeoman Generator
Better testing overall
Support customizing almost everything in the Karma config
Installs requested Karma plugins (and required ones not specified)
Writes Gruntfile config block and task

Notes:

Doesn't support CoffeeScript Gruntfiles

BREAKING CHANGES:

No longer adds Angular specific libraries
Default plugins, files have changed

Closes #44

btford commented 10 years ago

:+1:

eddiemonge commented 10 years ago

Please help with testing this:

npm install -g yo
git clone git@github.com:yeoman/generator-karma.git
cd generator-karma
git checkout -b eddiemonge-next master
git pull https://github.com/eddiemonge/generator-karma.git next
npm link
npm test

After that you can run yo karma or pass in options like yo karma --coffee.

eddiemonge commented 10 years ago

@passy @sindresorhus @addyosmani any comments or can i merge this?

eddiemonge commented 10 years ago

Updated. Updates made the code DRY'er too

eddiemonge commented 10 years ago

anymore?

sindresorhus commented 10 years ago

Yay. This is a really nice improvement @eddiemonge. Nice work!

I'm thinking we should do a blog post on this when it's released.

passy commented 10 years ago

This is great. +1 on a blog post. Doesn't have to be long, but would be nice to make more people aware of the changes. On May 12, 2014 10:24 PM, "Sindre Sorhus" notifications@github.com wrote:

Yay. This is a really nice improvement @eddiemongehttps://github.com/eddiemonge. Nice work!

I'm thinking we should do a blog post on this when it's released.

— Reply to this email directly or view it on GitHubhttps://github.com/yeoman/generator-karma/pull/51#issuecomment-42890297 .