search

yeoman / generator-karma

Yeoman generator for Karma
http://yeoman.io
BSD 2-Clause "Simplified" License
172 stars 48 forks source link

Missing folders in modules #54

Closed lauterry closed 10 years ago

lauterry commented 10 years ago

Hello

I've just run sudo npm install -g generator-karma

However, I encountered the following error : 

/usr/local/lib/node_modules/generator-karma/node_modules/yeoman-generator/lib/actions/actions.js:193
    throw new Error('Unable to read "' + filepath + '" file (Error code: ' + e
          ^
Error: Unable to read "/usr/local/lib/node_modules/generator-karma/templates/karma.conf.js" file (Error code: ENOENT).
    at read (/usr/local/lib/node_modules/generator-karma/node_modules/yeoman-generator/lib/actions/actions.js:193:11)
    at template (/usr/local/lib/node_modules/generator-karma/node_modules/yeoman-generator/lib/actions/actions.js:288:19)
    at module.exports.yeoman.generators.Base.extend.makeConfig (/usr/local/lib/node_modules/generator-karma/app/index.js:170:10)
    at /usr/local/lib/node_modules/generator-karma/node_modules/yeoman-generator/lib/base.js:381:14
    at processImmediate [as _immediateCallback] (timers.js:330:15)

I've checked the downloaded generator-karma folder and indeed the templatesfolder is missing.

Best regards

SBoudrias commented 10 years ago

Issue with the package.json files array: https://github.com/yeoman/generator-karma/blob/master/package.json#L16-L18

I really think it is a bad idea to keep that in our repo. It's not the first time it bites us and you have no way of finding the issue before it hits npm...

eddiemonge commented 10 years ago

fixed in https://github.com/yeoman/generator-karma/commit/24d8f10f843c3519304824960c7c0c8bc62a130d

lauterry commented 10 years ago

Nice !