search

yeoman / generator-karma

Yeoman generator for Karma
http://yeoman.io
BSD 2-Clause "Simplified" License
172 stars 48 forks source link

Add files-comments option #67

Closed Toilal closed 9 years ago

Toilal commented 9 years ago

This adds custom comments inside files property of karma.conf.

It is useful to add bower dependencies through wiredep using https://github.com/yeoman/generator-angular/pull/859

Toilal commented 9 years ago

@eddiemonge Could you review this PR please if possible ? with the one from angular generator ?

eddiemonge commented 9 years ago

how does it handle comments and files?

Toilal commented 9 years ago

Like files option but it adds // and doesn't wrap entries in quote... Im not sure if I understand your question...

eddiemonge commented 9 years ago

I mean if you have files wrapped in comments? would it support that?

Toilal commented 9 years ago

No it doesn't support this. It place comments, and then files.

Toilal commented 9 years ago

Maybe we can change the API and keep a single files options, and consider the entry as a comment if it starts with // (# for coffee) to keep ordering and be more flexible ?