search

yeoman / generator-karma

Yeoman generator for Karma
http://yeoman.io
BSD 2-Clause "Simplified" License
172 stars 48 forks source link

Add option to specify Karma reporters #68

Closed thewarpaint closed 9 years ago

SBoudrias commented 9 years ago

Could this be a list with available reporters?

eddiemonge commented 9 years ago

not really since there are lots and lots of reporters available.

eddiemonge commented 9 years ago

this is missing tests

thewarpaint commented 9 years ago

@SBoudrias There are a lot of reporters available, like Eddie said. @eddiemonge Right, I'll fix that.

SBoudrias commented 9 years ago

Thing is if there's so many, how can we expect a user to know them? I still think having a list/checkbox is the better UI for these. If necessary, trim the list down to the most used and make an option to manually specify the reporter if necessary.

sindresorhus commented 9 years ago

What @SBoudrias said. That would be a nice UX. Maybe list the 5 most popular ones ordered by popularity and have an option to manually specify.

thewarpaint commented 9 years ago

@eddiemonge Just added the tests. @sindresorhus @SBoudrias How would you get the most popular reporters? In the docs they only mention six: dots, progress, growl, junit, teamcity and coverage http://karma-runner.github.io/0.12/config/configuration-file.html. I think I could add those in a separate PR when I have some spare time.

sindresorhus commented 9 years ago

@thewarpaint That looks like a good default list. Just hardcode them in in that order.

eddiemonge commented 9 years ago

Did you mean to close this?

thewarpaint commented 9 years ago

Yes, I'll submit this from my company's fork sometime next week.