yeoman / generator-mobile

Scaffold out a mobile project based on Web Starter Kit
http://yeoman.io
918 stars 99 forks source link

foundation has "use strict" related errors out the box #28

Closed roblevintennis closed 10 years ago

roblevintennis commented 10 years ago

As a new user to mobile/foundation I should be able to get started with a sensible boilerplate with no errors...

mkdir yo-mobile-foundation && cd $_ && yo mobile

     _-----_
    |       |
    |--(o)--|   .--------------------------.
   `---------´  |    Welcome to Yeoman,    |
    ( _´U`_ )   |   ladies and gentlemen!  |
    /___A___\   '__________________________'
     |  ~  |
   __'.___.'__
 ´   `  |° ´ Y `

Out of the box I include HTML5 Boilerplate, jQuery and Modernizr.
[?] Would you like to include a mobile-first UI framework? Foundation
[?] Would you like to include layout boilerplate for your selection? Yes
[?] Would you like to generate multi-resolution images for srcset? Yes
[?] Would you like to remove click delays in touch UIs (eg iOS)? Yes
[?] Would you like screenshots of your site at various viewport sizes? Yes
[?] Would you like to use BrowserStack for device testing? No
[?] Would you like to include RequireJS (for AMD support)? No
[?] Would you like to convert your images to WebP? Yes
[?] Would you like to include a polyfill for async localStorage? Yes
[?] Would you like to include boilerplate for the Fullscreen API? Yes
[?] Should builds only include Modernizr feature-detects you actually use? Yes

.....MORE STUFF....

$ grunt
.....MANY STRICT RELATED ERRORS LIKE...
[L5:C5] E007: Missing "use strict" statement.
[L741:C23] W109: Strings must use singlequote.
[L12:C5] E007: Missing "use strict" statement.
[L21:C22] W003: 'isFullScreen' was used before it was defined.
ETC...ETC...
Warning: Task "jshint:all" failed. Use --force to continue.

Aborted due to warnings.

Result: Above errors out the box

Expected: Framework related jshint errors should be silenced and/or I should be able to opt out of running jshint on Foundation itself (esp. since it fails miserably)

On a new Macbook Air w/latest stuffs and:

yo --version
1.1.2

EDIT: This happens when selecting No Framework too, and looking closer the errors are sometimes related to app/scripts/fastclick.js...ERROR and app/scripts/fullscreensnippet.js...ERROR.

czegarram commented 10 years ago

Same ERROR Here.

addyosmani commented 10 years ago

This is now fixed in master.