search

yeoman / generator-mobile

Scaffold out a mobile project based on Web Starter Kit
http://yeoman.io
918 stars 99 forks source link

Review recommendation about apple touch icon #56

Closed arthurvr closed 9 years ago

arthurvr commented 9 years ago

It seems like we're recommending to place a file called apple-touch-icon.png in the root of your website. (right here)

This isn't really best practice anymore, because this leads to 2 unnecessary HTTP requests. See https://github.com/h5bp/html5-boilerplate/commit/345925f04384b59929d8d39ba428cef548921408 about this.

So, I would like to see a <link> for the touch icon. And of course we then should include some kind of placeholder icon with the project.

kevva commented 9 years ago

PR welcome.

arthurvr commented 9 years ago

PR welcome.

What image should I take as placeholder? I need 180x180

kevva commented 9 years ago

Use this:

apple-touch-icon

arthurvr commented 9 years ago

Opened a PR about this, see #59

kevva commented 9 years ago

Fixed by https://github.com/yeoman/generator-mobile/commit/410eaf2d2bfac3c284db29ed34313105d4e21698.