search

yeoman / generator-mobile

Scaffold out a mobile project based on Web Starter Kit
http://yeoman.io
918 stars 99 forks source link

Add missing semicolons to `index.js` #71

Closed arthurvr closed 9 years ago

arthurvr commented 9 years ago

Spotted some missing semicolons reading through the code.

addyosmani commented 9 years ago

LGTM.

Side: you've been on fire in the OSS world lately, @arthurvr. Nice work!

arthurvr commented 9 years ago

Thanks @addyosmani!

Reading through the rest of this repo, basically this repo will need a general "fix jshint errors" commit. I'il open a PR this night.

Off-topic here, but now this repo is wsk based, did somebody pinged the creator of https://github.com/brwr/generator-web-starter-kit? Just he knows there now is an official one.

x1ddos commented 9 years ago

@brwr FYI this generator-mobile is now based on Web Starter Kit.

jamesbrewerdev commented 9 years ago

@crhym3 Glad to hear it! I'll deprecate my repo.

arthurvr commented 9 years ago

Hi @crhym3! I'm preparing a PR to fix some JSHint errors, and there are over 170! I don't want to come over as rude, but we're using jshint for a reason... Did you used it? It's the handiest is if you install jshint right in your editor (e.g. https://github.com/Shutnik/jshint2.vim).

x1ddos commented 9 years ago

@arthurvr good point. I haven't ran this project through jshint yet (instead, relying on 40 tests) but was going to. I guess I'm used too much to Go where gofmt takes care of it.

I'll make sure to fix all jshint suggestions next week.