search

yeoman / generator-mobile

Scaffold out a mobile project based on Web Starter Kit
http://yeoman.io
918 stars 99 forks source link

Environment config needed for tests should be defined in package.json #75

Closed sindresorhus closed 9 years ago

sindresorhus commented 9 years ago

In the test run script in package.json, not in .travis.yml.

https://github.com/yeoman/generator-mobile/commit/14dd99b4896ca5dc63fc7f9bee068048804f997f#commitcomment-9751194

x1ddos commented 9 years ago

There is nothing to configure. Like I was saying in the comment, the git-related tests are not being run, they are not failing.

There's more than just git configuration. A user might not even have git installed - I'm not going to ask them to install it or mess with their git configuration just to run those tests.

I believe before_script section of .travis.yml is where it belongs.

sindresorhus commented 9 years ago

What's the point of tests that only run sometimes?

x1ddos commented 9 years ago

It's called CI. They always run on Travis.

On 15 February 2015 at 10:39, Sindre Sorhus notifications@github.com wrote:

What's the point of tests that only run sometimes?

— Reply to this email directly or view it on GitHub https://github.com/yeoman/generator-mobile/issues/75#issuecomment-74412316 .