yeoman / generator-polymer

Scaffold out a Polymer project
http://polymer-project.org
926 stars 149 forks source link

Add newly created elements to test suite as well #159

Closed pankajparashar-zz closed 9 years ago

pankajparashar-zz commented 9 years ago

I think its a good idea to add newly created elements to the test suite, each time we create a new element using,

$ yo polymer:element my-element

Alongwith creating the directory structures for the new element inside the elements directory, we could add my-element.html to the test directory as well.

.
├── test
│   ├── index.html
│   └── my-element.html

Additionally, the index.html can also be updated to include the new element,

WCT.loadSuites(['yo-greeting-basic.html', 'yo-list-basic.html', 'my-element']);
robdodson commented 9 years ago

I agree! Would you be interested in putting together a PR for this?

pankajparashar-zz commented 9 years ago

Yeah sure! Let me give my best shot.

arthurvr commented 9 years ago

@pankajparashar Did you every get to opening a PR? We're still interested :)

robdodson commented 9 years ago

Hey @arthurvr and @pankajparashar. I haven't talked about it much publicly but there's a big refactor of the generator coming which will be based around a starter kit that @addyosmani is building. I would suggest holding off on PRs until I get us switched over to that. Probably around end of May

arthurvr commented 9 years ago

@robdodson @addyosmani That's fine to me and that sounds awesome. Though you should probably have the discussions in public :)

robdodson commented 9 years ago

The generator has been updated now, so we can start investigating this again. I think this should hopefully be pretty easy if anyone wants to do a PR for it?

BLamy commented 9 years ago

@robdodson Also this.