Closed open-cipher closed 8 years ago
Hey @akshayKrSingh
Thanks for sending over the PR. I really appreciate the work but don't think we're going to include it. There are a couple reasons for this. The primary one is that I'm a little wary of papering over bower and trying to stay on top of any changes it might throw at us. The second is that you don't always want everything imported into your elements.html
file (that's why the element subgenerator defaults to 'no'). You only want that behavior occasionally. Usually you want to import a dependency inside the element that's actually using it.
But I do want to thank you for spending time putting together this PR, it's really well written and I'd like to incorporate the bug and style fixes you included (maybe those could be a separate PR). If you're thinking about other improvements, open an issue first so we can discuss and :+1: the idea. Again, thank you for the work and sorry we can't merge this one.
That's ok. Although It was fun creating that sub-generator anyways :smile:
I'll create a separate PR including the bug noted by @sindresorhus and few style changes, so that you can merge them if necessary.
@robdodson : I've tried adding
yo polymer:bower
sub-generator to install and append polymer-elements through bowerChange Log
,
fromapp/index.js
What's Happening under the hood
yo polymer:element
with the only difference being theelement-name
entered is installed via bower.main
property from bower.json.main
property, importing the elements toapp/elements/elements.html