Use generator v0.20. Close Gh-35

yeoman / generator-polymer

Scaffold out a Polymer project

http://polymer-project.org

926 stars 149 forks source link

Use generator v0.20. Close Gh-35 #229

Closed robdodson closed 8 years ago

robdodson commented 8 years ago

Updated to latest yeoman-generator and did a ton of clean up. Could definitely use a look from @arthurvr @addyosmani @samccone

robdodson commented 8 years ago

Anyone else care to take a look? I'd like to merge this soon-ish because PSK has updated to a new version. Apologies for the big PR :\

addyosmani commented 8 years ago

Reviewed. Overall this LG to land.

High-level comment: there are some checks you're making for WCT usage against both the PSK base and seed-element that could be generalised (e.g rather than validating WCT and test-fixture presence in two places for package.json, you could do it in just one and turn it into a utility function). You could similarly do the same for the npmignore/gitignore checks.

These are minor nits however and can be looked at later. Let's land this.

robdodson commented 8 years ago

great thanks @addyosmani!