search

yeoman / generator-polymer

Scaffold out a Polymer project
http://polymer-project.org
926 stars 149 forks source link

Fix incorrect npmignore sniffing #242

Closed samccone closed 8 years ago

samccone commented 8 years ago

Fixes #240

Regression introduced in https://github.com/yeoman/generator-polymer/commit/f9e2d0da558d0b71525e7019b14667d9f2381f42#diff-2018087f584c4398b5c3a23fc0e5f9dbR60

cc @addyosmani @robdodson

(tested locally this time, by renaming .gitignore to .npmignore)

robdodson commented 8 years ago

Change looks good to me On Oct 23, 2015 5:56 AM, "Sam Saccone" notifications@github.com wrote:

Fixes #240 https://github.com/yeoman/generator-polymer/issues/240

Regression introduced in f9e2d0d#diff-2018087f584c4398b5c3a23fc0e5f9dbR60 https://github.com/yeoman/generator-polymer/commit/f9e2d0da558d0b71525e7019b14667d9f2381f42#diff-2018087f584c4398b5c3a23fc0e5f9dbR60

cc @addyosmani https://github.com/addyosmani @robdodson https://github.com/robdodson

(tested locally this time, by renaming .gitignore to .npmignore)

You can view, comment on, or merge this pull request online at:

https://github.com/yeoman/generator-polymer/pull/242 Commit Summary

  • Fix incorrect npmignore sniffing

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/yeoman/generator-polymer/pull/242.

robdodson commented 8 years ago

@samccone just catching up on things now that I'm back home. Do you think this is ok to merge?

samccone commented 8 years ago

Yep a merge and new release shoukd be swell