search

yeoman / generator-polymer

Scaffold out a Polymer project
http://polymer-project.org
926 stars 149 forks source link

El aliases should copy from template dir #244

Closed robdodson closed 8 years ago

robdodson commented 8 years ago

@samccone PTAL. I think this fixes the issues with folks running yo polymer:element which is just an alias for yo polymer:el https://github.com/yeoman/generator-polymer/issues/232#issuecomment-147847138

samccone commented 8 years ago

Interesting, have you been able to run into this locally? When I have been testing the gitignore issue I have not hit this one

robdodson commented 8 years ago

@samccone yeah I was able to reproduce it locally. Try running yo polymer:element x-foo instead of yo polymer:el x-foo. The yo polymer:element version will break because it's looking for the templates dir in the elements dir, but that folder doesn't exist. Because element just requires el, this little workaround tells the system to use el's templates dir

robdodson commented 8 years ago

@samccone @addyosmani @arthurvr are you guys ok with me merging this?

samccone commented 8 years ago

:+1: tested locally w/o the patch and errored, then tested locally w/ patch and all good, thanks @robdodson

robdodson commented 8 years ago

yay thanks @samccone !