search

yeoman / generator-polymer

Scaffold out a Polymer project
http://polymer-project.org
926 stars 149 forks source link

Fix seed generator ignore glob #245

Closed jshcrowthe closed 8 years ago

jshcrowthe commented 8 years ago

Thanks for the awesome generator! I have been using it more of late and it is proving to be a super useful tool, so thanks again!

I have been specifically using yo polymer:seed and found that the glob negation that is happening ( https://github.com/yeoman/generator-polymer/blob/master/seed/index.js#L86) isn't filtering out the proper paths. Upon closer inspection it seems that in v5 of node-glob the negation has to be manually turned on with a nonegate: true flag passed to the globOptions prop of fs.copy.

As I was digging around I also found that they recommended using the ignore property of globOptions instead (https://github.com/isaacs/node-glob#comments-and-negation). So I wrote a quick PR to address the bug (following the ignore prop suggestion) and added a test to verify.

robdodson commented 8 years ago

Just started reviewing :)

:octocat: Sent from GH.

robdodson commented 8 years ago

LGTM! Thanks for the PR!

jshcrowthe commented 8 years ago

No problem! Thanks again for the awesome generator, this is the first one I've actually convinced myself to use and I'm glad I did.