search

yeoman / generator-polymer

Scaffold out a Polymer project
http://polymer-project.org
926 stars 149 forks source link

Support Github Enterprise repos #252

Closed adamschnaare closed 8 years ago

adamschnaare commented 8 years ago

Found this tool quite useful and wanted to be able to use it from within Github Enterprise repos. I think the only thing missing was references to a variable hostname as opposed to assuming git@github.com/...

robdodson commented 8 years ago

Just started reviewing :)

:octocat: Sent from GH.

adamschnaare commented 8 years ago

I would agree in retrospect. I think I was a bit biased by my immediate need. Total noob question here: should I make the edits in my repo and just commit? What would be a next step?

robdodson commented 8 years ago

@adamschnaare yeah so long as you're working on this branch in your repo it'll update the PR

adamschnaare commented 8 years ago

Sorry for the delay! Who doesn't like late Christmas presents? At any rate:

robdodson commented 8 years ago

Just started reviewing :)

:octocat: Sent from GH.

robdodson commented 8 years ago

Merged in 5a1c7f99ae05ab16e51196c2d800d5244ed4659c

Thanks for working on this! 🍰

Btw I'd recommend rebasing your feature branch from master instead of merging from master. Merging into the branch creates a kind of wonky git history, rebasing is usually a lot cleaner. If you haven't worked with rebasing before the Git Book has a pretty solid guide on it. https://git-scm.com/book/en/v2/Git-Branching-Rebasing

adamschnaare commented 8 years ago

Thanks for the pro tip! I'll review that for sure. And it will be quite helpful as I'll be doing a lot of this with repos on some Github enterprise repos, hence the work on this project.

robdodson commented 8 years ago

:+1: